Christian Edward Jackson-Gruber

Results 154 comments of Christian Edward Jackson-Gruber

Sorry - we didn't get to it in API review this week. But at a high level, I like the concept. On Tue, Oct 7, 2014, 08:09 Kurt Alfred Kluever...

I admit to some anxiety about relying on reflective access, but I can see why you're doing it. I would suggest that in the process, that reflective access actually be...

Ah, I see what you mean. I can rework this to remove the usages, given that they're totally vestigial at runtime. I can see the noise problem downstream, because of...

It turns out not to be as rare as one might think, especially where string parameters are handled or in systems with stringly typing. I see a lot of isNullOrEmpty...

... damn. I didn't think at all about `assertThat(foo).isAnyOf(null, "");` . I actually kind of like it, though yeah, it's not obviously completable. The other thing is that you can't...

Ping @cpovirk. :) (No rush if you're busy, but wanted to make sure it didn't fall in the cracks.

Hey @cpovirk - was just showing how github worked to a friend, and realized I have this Pr still hanging on. Any thoughts around moving it forward?

So... yeah, we can do that. The only issue was whether y'all were ok with us adding a kotlin runtime dep - but since that will only be in the...