rules_kotlin
rules_kotlin copied to clipboard
Fix Bazel incompatible changes
I'd like to be able to build rules_kotlin with --all_incompatible_changes
:
bazel test :all --all_incompatible_changes
It may not be possible to fix every issue now due to transitive dependencies, but we should try to fix the issues from this repository.
Update: All incompatible flags can be enabled, except --incompatible_disallow_legacy_javainfo
.
Bazel 0.21 fails on Android with:
ERROR: /Users/steeve/XXX/BUILD.bazel:42:1: in deps attribute of android_library rule //XX/XXX:android_library_base: android_library will be deprecating the use of deps to export targets implicitly. Please use android_library.exports to explicitly specify targets this rule exports. Since this rule was created by the macro 'kt_android_library', the error might have been caused by the macro implementation in /private/var/tmp/_bazel_steeve/309ac22c92b055a3e3f78825fe63406b/external/io_bazel_rules_kotlin/kotlin/internal/jvm/android.bzl:31:16
We're starting to get further --incompatibles on recent bazel. If we don't update these rules to keep in step with the accelerated bazel release schedule, thigns are going to get very frustrating for users very fast.
Already you have
--incompatible_java_common_parameters
breaking clean build on bazel 3.7.
Triaging this up, since while the original issues are obsolete, we need to bump the present state of the repo to be workable with recent bazels.