Chris Fallin

Results 323 comments of Chris Fallin
trafficstars

Thanks @elliottt for bringing this up. I have some thoughts on this inspired by our conversations over the past week, together with our experience with this aspect of ISLE over...

Thanks @jameysharp for your thoughts here! > We could instead require every rule to express all of its preconditions, and have a separate way of expressing the cost model. That...

> Maybe by having a fuzzer which changes rule priority and disables rules at random and then doing differential fuzzing of the program execution with the rule set used for...

We had a good discussion on this issue today in the Cranelift meeting; thanks all for the input! I unfortunately didn't take detailed comment-by-comment notes but by the end of...

This needs a cargo-vet update; @bnjbvr would you be willing to vet the diff in `sha2`?

Thanks for tracking this down, @koute! Yes, I agree that aligning loop headers to cache-line boundaries makes sense. Probably as a compile-time option, when opts are enabled (debug code is...

This might be a good starter issue for someone to tackle. The main steps I see this taking are: - Convey a notion of "loop header block" to lowered blocks...

It's interesting that this was hit only when egraph-based optimization is on -- I suspect because of the different way that constants are rematerialized... In any case, I do think...

Also, just to note it here: if at all possible, I'd prefer for us to wait to merge this until after my mid-end work in #4953 is merged, if only...

This is definitely interesting to consider! One thing that has occurred to me since our discussion is that turning the checker on in tests may have somewhat less value than...