Chris Fallin

Results 333 comments of Chris Fallin
trafficstars

Oh, for sure, I didn't know we were waiting on something here; sorry! I was waiting for your go-ahead to merge. FWIW the PR is still marked as a draft;...

I personally think it would be nice to have this, but it's not a small task to build, and no one currently has the time to do it. If you...

> This is way out of my league so likely a stupid question; but if I build a so/dll of all the cranelift crates like cranelift = "0.89.0" using cargo,...

Yeah, actually, that's totally fine with me too. Once #5020 lands we'll fuzz with-egraphs against no-egraphs so we'll have full coverage; I was thinking it might be nice to have...

Yes, actually, we should do that too; I'll follow up with a PR.

@jlb6740 a few thoughts: - Can we label "Averages" at the bottom "Geomeans" (and to check: they are geometric means?) so the reader knows what kind they are? - To...

> These are averages of what we decided to call the change factor (python pandas calls it percent change). I definetly don't think we want to take the geomean of...

Two ideas for bounding stability: - We might want to exclude instantiation time altogether from these runs. I'd prefer not to, from first principles, but they seem to have significantly...

> This is more something for the sightglass-analysis crate than the github bot, IMO. The github bot shouldn't be growing anything other than what is needed to run sightglass on...