eui
eui copied to clipboard
elastic
WIP. First pass at CSS before spread child props ESLint rule.
Summary
Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.
Checklist
- [ ] Checked in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation
- [ ] Checked Code Sandbox works for any docs examples
- [ ] Added or updated jest and cypress tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes
- [ ] Updated the Figma library counterpart
- [ ] A changelog entry exists and is marked appropriately
Preview documentation changes for this PR: https://eui.elastic.co/pr_6257/
Preview documentation changes for this PR: https://eui.elastic.co/pr_6257/
Preview documentation changes for this PR: https://eui.elastic.co/pr_6257/
I'll look over the components with linting changes for visual regression. LMK if this feels like a breaking change and I'll add the label.
This looks and works great. I just have a couple very minor comments, fantastic work on this Trevor!
edit to add: this is not a breaking change, just IMO, and I agree it doesn't need a changelog
Thank you @constancecchen for the 💯 code change suggestions. I turned on Prettier format on save, so it broke some of my one line const declarations into 2-3 and wrapped single arrow function arguments.
I esp liked the suggestion to move early return guard clauses closer to their declarations. Moving those lines around provided clearer intent.
Preview documentation changes for this PR: https://eui.elastic.co/pr_6257/
Preview documentation changes for this PR: https://eui.elastic.co/pr_6257/