Cristian Velazquez

Results 9 comments of Cristian Velazquez

1.- I think it should be an option to add more flexibility. Although many clients put a default value if there is none provided by the user. For instance grpcurl:...

1.- I think adding the option can be done in a separate diff. 2.- I will try and fix if we can set the host:port for the actual peer chosen....

It seems that the current API doesn't support to set the authority per host. The current version that yab uses has the following (https://github.com/grpc/grpc-go/blob/v1.24.x/clientconn.go#L262): ``` if creds != nil &&...

I check one more time and yes it seems there is no way to inject the right authority because the API doesn't provide a way. The authority header comes from:...

Yeah, it shouldn't be an issue. The problem is that because of the load balancing that it has, the grpc AP doesn't provide a way to set an authority per...

@vdarulis @mway @andrewmains12 could you take a look at this?

@vdarulis done. The benchmark improved slightly: Note: I changed the names of the benchmarks because they were not reflecting what was actually happening.

> An alternative to increasing GOMEMLIMIT is to switch to a GOGC-based GC trigger once you get close to the limit. This is effectively just a softer limit, but defined...

@mknyszek I thinks the correct formula is: ``` 100 * (/gc/heap/goal:bytes) / (/gc/heap/live:bytes + /gc/scan/stack:bytes + /gc/scan/globals:bytes) - 100 ``` or am I missing something?