tally icon indicating copy to clipboard operation
tally copied to clipboard

Use multiple subscope buckets

Open cdvr1993 opened this issue 2 years ago • 3 comments

We have an application that has a cpu limit of 30 cores. During the start of it we see a considerable increase in latency 20ms -> 100ms. After tracing it down, we found the source of the problem in the lock contention from the subscope. We tried this change and were able to remove any latency increase.

I am also adding a parallel benchmark so that it is easier to see the lock contention.

Benchmarks Current Screen Shot 2022-10-04 at 9 09 05 AM

After the change Screen Shot 2022-10-04 at 9 07 56 AM

cdvr1993 avatar Oct 05 '22 18:10 cdvr1993

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 05 '22 18:10 CLAassistant

@vdarulis @mway @andrewmains12 could you take a look at this?

cdvr1993 avatar Oct 05 '22 18:10 cdvr1993

@vdarulis done. The benchmark improved slightly:

Screen Shot 2022-10-13 at 10 08 47 AM

Note: I changed the names of the benchmarks because they were not reflecting what was actually happening.

cdvr1993 avatar Oct 13 '22 17:10 cdvr1993