Cosimo Damiano Prete

Results 195 comments of Cosimo Damiano Prete

@sunix after the rebase with master, the compilation now fails harder than before: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.5.1:helpmojo (help-goal) on project openshift-maven-plugin: Execution help-goal of goal org.apache.maven.plugins:maven-plugin-plugin:3.5.1:helpmojo failed:...

@sunix all green. You can proceed if you like :) To work around the error I wrote about before, I just triggered the build again as suggested in the output...

I usually like to encapsulate and hide such edge cases, also because in the future the condition(s) triggering a case may change and, in such a case, you would need...

@sunix unless I've by accident missed something, all the discussions are resolved. Maybe just have a final rapid look if you can :)

Hi @sunix. I don't think it makes so much sense to split it into multiple PRs since, in the end, it's just a small refactoring. Moreover, it would take me...

I remember this 😂 I fixed it as well as part of https://github.com/eclipse/jkube/pull/1416 but without recurring to the real path, which would break in case of non-existing paths (ie. mocks)

> @cdprete I guess we could close it as duplicate, once #1416 is merged ? Yep

Hi. I'm using JUnit 5, but even JUnit 4 is fine if for you is better (I can convert the code accordingly).

Sorry, I read just the comment about the test framework and I missed the next one ;) I'll have a look at it. Thank you.

Hi. I can confirm the example works, but how to test prompt properties? For example, that a proper color is set? --- Nevermind. I can of course fetch the properties...