Christopher Horn
Christopher Horn
Stumped on the failing test at the moment which seems totally unrelated to such a trivial change. Oddly my machine fails faster and harder than this run on Ubuntu 18.04...
@Nick-Hall please review my comment above if you missed it. I would argue since this PR does not change the existing behaviour that should be treated as a separate issue...
I use a copy of this class with these changes in my CardView, and was hoping to avoid needing to keep a one off for that purpose.
Okay, understood, I will close this one.
@mbalk if "Include only living people" is checked and "Include death dates" is checked then I would expect "Include only living people" to still be honored but all the deceased...
This looks good to me.
Removed the pylint hints as well, think this is ready.
Factors out EventBase as well now to reduce code duplication and for future addition to Place