gramps icon indicating copy to clipboard operation
gramps copied to clipboard

Add toolbar icons for Preferences and Plugin Manager

Open DaveSch-gramps opened this issue 4 years ago • 12 comments

Add Icons to open Preferences and the Plugin Manager

Feature Request #12030

DaveSch-gramps avatar Oct 26 '20 15:10 DaveSch-gramps

These new icons don't appear to conform to the Tango icon guidelines. See our Gramps icon set wiki page for further details.

The jigsaw piece is a good choice for addons. There should be a free Tango style icon available.

For preferences, I think that Tango uses a spanner and screwdriver rather than a cog. However, I believe that there is a cog in the standard Tango library.

Nick-Hall avatar Oct 26 '20 17:10 Nick-Hall

I'll substitute the Screwdriver/Spanner icon for the Preferences icon.

I like the idea of the Puzzle piece and had found a black icon that I colored in the gramps program folder \share\icons\adwaita

No puzzle piece in the Tango folder or the associated GNOME folder.

Does this puzzle icon fit in with the theme from SVG Repo?

DaveSch-gramps avatar Oct 26 '20 22:10 DaveSch-gramps

A closer inspection of existing icons shows that the Screwdriver/Spanner is already superimposed on the generic gramps-view icon to configure views, gramps-config.

Will switch to the cog from the Tango Categories.

DaveSch-gramps avatar Oct 26 '20 22:10 DaveSch-gramps

My brain worked overtime last night and now realize the puzzle icon I recommended from SVG Repo above is not appropriate.

Recommending Gnome-preferences-other.svg

DaveSch-gramps avatar Oct 27 '20 11:10 DaveSch-gramps

I'm not sure why you don't think the puzzle piece for addons is 'not appropriate'; when I look up addons icon in Google, I see a large preponderance of puzzle icons... Gnome-preferences-other.svg doesn't seem to be a good choice.

prculley avatar Oct 27 '20 14:10 prculley

The puzzle piece I was suggesting as the alternative to the one I had originally proposed (and Nick H said was not up to standards) was of two colored puzzle pieces. This is the icon that I was deeming "not appropriate".

An alternative that I was exploring is this single golden yellow puzzle piece icon. It has extra lines at the top and left which I removed.

The Gnome-preferences-other.svg was a "safe" stock alternative.

I am open to your (and others) input.

DaveSch-gramps avatar Oct 27 '20 15:10 DaveSch-gramps

I quite like the mozilla puzzle icon. It has highlighting which gives it a slight 3D effect.

Nick-Hall avatar Oct 27 '20 15:10 Nick-Hall

adwaita dark

adwaita light

So these icons are good?

DaveSch-gramps avatar Oct 27 '20 16:10 DaveSch-gramps

Yes. They look good.

Nick-Hall avatar Oct 27 '20 17:10 Nick-Hall

Codecov Report

Merging #1139 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   41.28%   41.28%           
=======================================
  Files        1060     1060           
  Lines      143397   143397           
=======================================
  Hits        59204    59204           
  Misses      84193    84193           
Impacted Files Coverage Δ
gramps/gui/grampsgui.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c567b9e...94477f8. Read the comment docs.

codecov-io avatar Oct 27 '20 21:10 codecov-io

Rebased.

Nick-Hall avatar Mar 07 '22 19:03 Nick-Hall

Added a commit to make changes immediate.

Perhaps we could make a few other icons configurable? The clipboard, tools dialog and reports dialog would appear to be candidates.

Nick-Hall avatar Mar 08 '22 00:03 Nick-Hall

This looks good to me.

cdhorn avatar Mar 05 '23 02:03 cdhorn