Calendarreport

[mbalk]

[codecov-io]

Codecov Report

Merging #1163 (aaa9ac7) into master (7443cf4) will increase coverage by 0.01%. The diff coverage is 75.59%.

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   41.17%   41.18%   +0.01%     
==========================================
  Files        1062     1062              
  Lines      144609   144654      +45     
==========================================
+ Hits        59538    59578      +40     
- Misses      85071    85076       +5     

Impacted Files	Coverage Δ
gramps/plugins/drawreport/calendarreport.py	86.21% <75.59%> (-2.04%)	:arrow_down:
gramps/gen/utils/symbols.py	87.50% <0.00%> (+1.56%)	:arrow_up:
gramps/plugins/test/exports_test.py	91.35% <0.00%> (+2.46%)	:arrow_up:
gramps/gen/plug/docgen/fontscale.py	90.66% <0.00%> (+5.33%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7443cf4...aaa9ac7. Read the comment docs.

[SNoiraud]

You should use the symbols functions: get_symbol_for_string or get_symbol_fallback for all symbols except the death symbol. You have an example in gramps/gui/widgets/fanchart.py

From 5.1, we can select our proper death symbol, so you must use: death_symbol_idx = config.get('utf8.death-symbol') or death_symbol_idx = self.uistate.death_symbol self.dth = self.symbols.get_death_symbol_for_char(death_symbol_idx)

[mbalk]

You should use the symbols functions [...]

Thank you for your review! I pushed some changes.

[Nick-Hall]

Rebased.

This looks good to me. I'll ask for people who use this report to test it.

[Nick-Hall]

Testing should include:

• Check that the new "Include death dates" option works.
• Check that the birth, marriage and death symbols appear correctly.
• Check that no existing functionality is adversely affected.

[cdhorn]

@mbalk if "Include only living people" is checked and "Include death dates" is checked then I would expect "Include only living people" to still be honored but all the deceased people are showing up on the calendar anyway. Other than that this looks good to me.