Christoph Deil
Christoph Deil
@wegenmat - For the task list above, maybe you could add one point that these datasets should be entered into gamma-cat properly: ``` input/data//no_paper/lightcurves/tev-000049/httpveritas.sao.arizona.edu.ecsv input/data//no_paper/lightcurves/tev-000049/PhD_Martin_Kestel_MPI_Munich.ecsv input/data//no_paper/lightcurves/tev-000049/reference_empty_1.ecsv input/data//no_paper/lightcurves/tev-000049/reference_empty_2.ecsv input/data//no_paper/lightcurves/tev-000091/httpveritas.sao.arizona.eduSummariessummarymrk501.table_1.ecsv input/data//no_paper/lightcurves/tev-000091/httpveritas.sao.arizona.eduSummariessummarymrk501.table_2.ecsv input/data//no_paper/lightcurves/tev-000091/reference_empty.ecsv...
I just now noticed a small issue with the LC data we have. For a few A&A papers the folder name was incorrect (`&` character dropped, should be encoded `%26`)....
Sure, go ahead. You can do that now. We have no schema or validators for LC yet, so I think at the moment any info you put into the ECSV...
I've addded the missing papers to `input/gammacat/gamma_cat_dataset.yaml`. There's still this, i.e. the check needs to be adapted to work on index files and properly excluded file lists: ``` ERROR:gammacat.catalog:Datasets in...
@pdeiml - `gamma_cat_dataset.yaml` is the configuration file that controls the content of the catalog. You can see that it's used from `catalog.py` here: https://github.com/gammapy/gamma-cat/search?utf8=%E2%9C%93&q=gamma_cat_dataset.yaml+&type= Of course, a fix for this...
That sounds like a regression bug then. Initially when I wrote and used this, `gamma_cat_dataset.yaml` from the input folder was used. Can you start by making a PR fixing this?...
@pdeiml - Thank you!
> You want to add data_id in addition to paper_id or instead of it? Instead. - Put `paper_id` where available. - If not available, put `data_id` Then all info is...
OK, one field. I don't like `paper_id` (because some aren't papers) and I don't like `data_id` (because that sounds more like dataset ID, but a given paper can have multiple...
I don't know which cases @Konstancja and @wegenmat have. But a typical case is: 1. source detection gets announced in a presentation or poster 2. a year later the proceeding...