Christoph Deil

Results 472 comments of Christoph Deil

I would stronly prefer to only have one single config file for the catalog. I.e. my suggestion would be to change this file https://github.com/gammapy/gamma-cat/blob/master/input/gammacat/gamma_cat_dataset.yaml to add the extra info, e.g....

I would leave `reference_id` as-is, and optionally if there is `reference_id_sed` or `reference_id_lc`, use that for SED or LC (and otherwise default to use the same for all). I.e. minimal...

@wegenmat - Welcome to Github!

This was partly implemented by @wegenmat in #26. EDIT: task list removed here, added by @wegenmat in a copy below.

@Konstancja - That's pretty cool that you got that username, and I also like your avatar! :-) --- For units: Do you agree that using proper units for fluxes is...

> One more thing: some of the fluxes are ULs, which we converted from actual flux measurements, if flux_error > flux. We did something like UL = flux + 3\*...

@wegenmat - Thanks for updating the task list. I'm changing a lot of things in gamma-cat today (folder, filenames, scripts). Please wait for a day before continuing the work on...

I'm going though, changing the sed files to "-sed.ecsv" now, and fixing up LC issues as I see them. First one is an apparently empty `input/data/2001/2001ApJ...546..898A/91_2001ApJ...546..898A.ecsv`, which I removed in...

Sorry, it wasn't empty as I stated. But a duplicate of `input/data//2001/2001ApJ...546..898A/tev-000091-lc.ecsv`, so it was OK to remove.

One more LC change: in e7a940c I removed `input/data/2009/2009ApJ...691L..13D/49_2009ApJ...691L..13D.ecsv`. It was an old duplicate of `input/data/2009/2009ApJ...691L..13D/tev-000049-lc.ecsv`.