Christoph Deil
Christoph Deil
I tried to build `cdshealpix` and for now am stuck here: ``` $ pip install -r requirements-dev.txt ... Compiling pyo3 v0.6.0 Running `rustc --edition=2018 --crate-name build_script_build /Users/deil/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.6.0/build.rs --color always --crate-type...
@bmatthieu3 - Now I get this compile error with `cdshealpix`!? https://gist.github.com/cdeil/40439c3eb0491f8dae121fc2a03e26a6#file-gistfile1-txt-L241
@dstndstn - Do you understand this? Is "double" 64 bit and "long double" more? Or are both 64 bit and just the C functions called are higher precision somehow? Maybe...
As commented by @lpsinger in https://github.com/astropy/astropy-healpix/pull/71#issuecomment-401027171 - this should still be implemented, but we should change to `ufuncs` first.
@mreineck - Thank you! That is very kind and helpful that you're giving your time and reviewing this code. cc @dstndstn and @fxpineau might also be interested in this.
Agreed that "full" was a complete misnomer and that `overlap="any"` is good. > Implementation-wise, doing it in core.py in Python/Numpy is fine - if we want to avoid making temporary...
đ This is one thing I'm missing in https://github.com/hipspy/hips/pull/109 , trying to use `astropy-healpix` for `hips`. I'll implement some utility function there now, but having direct support for `frame={âicrsâ, âgalacticâ,...
This is the `make_frame` helper function I'm using in `hips` for now: https://github.com/hipspy/hips/pull/109/files#diff-82f8d9d870d0601c2c9452cdd650e703R207
I don't know ... this silently fails (returns `None`): ``` frame_transform_graph.lookup_name('spam') ``` For now I'll stick with my helper function.