Marc Mueller

Results 381 comments of Marc Mueller

Just a small warning: I've worked on the methods you mentioned above. Getting it right in all previous cases wasn't easy, especially testing it. We had to deal with multiple...

Interesting, the issue only occurs with `dict` as variable name, not for example `d`.

I meant this here: ```py from typing import List def parse_dict(dict_object: List[dict], name: str) -> dict: for d in dict_object: # iterator key is 'd' not 'dict' if d.get("name") ==...

Just stumbled across this one. IMO the change isn't worth the additional effort. There are better more practical security improvements we can implement. Haven't had the time to do so...

I'm not sure the issue hasn't been resolved in the meantime. Home-Assistant uses `-j 2` be default, even for all CI runs, and also uses custom plugins. There has been...

> But please note that generics are expected to work with `collections.abc` with all Python versions in stubs or when using the future import. Good point! The idea originally was...

I've opened #6262 to have some basis for a discussion. `_Alias()` is a good idea. It seems though that `pyright`, `mypy`, (and others ?) need some work to support it.

> Is it simply the subset of symbols listed in PEP 585 that begin with `collections.abc`? Not quite. If I didn't miss any, these should be it. ``` # These...

I just realized that my comment about the Python version can be a bit confusing and not really relevant to the issue. They are the versions where the classes became...

I'm having some issues implementing the required mypy changes. The easy part is updating the type alias list here: [mypy/nodes.py](https://github.com/python/mypy/blob/4037b6a082556dab352a182c7671939073f25b26/mypy/nodes.py#L110-L136). The problem I've now come up against is that both...