Marc Mueller
Marc Mueller
> What about adding an option/global variable to `pylint` similar to `tree_rev`? We could support both versions in the codebase like we would do in `astroid`? Not sure how practical...
I reverted passing `self.tree_rev` to each `self.visit` call. After looking at #1389, it became clear that the benefit of slightly improved typing wouldn't be worth the additional effort required. _I'll...
@Pierre-Sassoulas You're right the proposal would complicate maintenance and doesn't even solve all issues. I'm a bit glad we didn't do it 😅 The big issue with the proposal is...
In theory it's a good idea. However I would prefer not to change it before the Import nodes are re-done at some point. We may want to add a dedicated...
I agree, this change should definitely have tests! As for the code itself, the addition seems reasonable. I don't know what your opinion is @hippo91, but I would prefer to...
We will also need to check for unintended side effects with `pylint` before merging it.
I was the one who argued against merging https://github.com/PyCQA/astroid/pull/1218. Although we should try to keep roughly the same structure as the `AST`, astroid in its current form isn't and more...
Thanks for taking the time to explain it! > Overall these utility function are very useful and I think astroid should offer the alternatives for functions that are present in...
> I don’t see why you say that I’m using astroid for a purpose that it wasn’t designed for. The way I see it, astroid is there to provide ast...
> @cdce8p After your comments I found out that we were actually missing some nodes which could have access to the same attributes. > `IfExp` is now the only node...