Marc Mueller

Results 381 comments of Marc Mueller

I understand the concern. The question would be is there a solution to make it work? There is the `--skip-magic-trailing-comma` option, maybe we could add a `--skip-existing-parentheses` one? Obviously, I...

@pradyunsg Personally, I would still like to see this move forward. However I feel that at the moment this would be a waist of my time, as it's not yet...

I've marked the PR to as draft today. Unfortunately, I won't have time to work on it anytime soon. If anybody wants to pick this up and explore if it...

> It could also fit nicely under the `--preview` flag (#2752). But we still need some discussion in the original issue. Many thanks for the work you've already put in!...

@bgreen-litl Would you be able to take a quick look? This issue is preventing us from upgrading to v2.

_I haven't followed the discussion around this check so it might have come up already._ Why was this not implemented as an optional extension? From what I can tell there...

I would recommend this: ```py if action in { VariableVisitConsumerAction.RETURN, VariableVisitConsumerAction.CONSUME, }: return ``` It's a single set contains operation that should be faster and easier to read, especially compared...

> That proposal surely is much easier on the eye, and I'm not surprised at all that it's more performant. However it arguably is not _correct_, `==` vs `is` is...

After the discussion so far, I don't see a need for such a checker. * In case someone uses `IntEnum` or `StrEnum` they most likely what it to compare to...

> > > As for Colored.RED == Color.RED, that will already be false since enums are singletons. > > > As noted in earlier comments here, this does not hold...