Carlson Büth

Results 44 comments of Carlson Büth

@dkrako thank you for the valuable feedback, I integrated some of them now, and follow-ups could be the preprocessing utilities: - `samples_to_events()`: per‑sample labels (e.g., fixation/saccade/blink) into event rows -...

> codecoverage complains about a single uncovered line. as #1371 will make this irrelevant anyway you can just add `#pragma: no cover` there I read your comment just after adding...

Two suggestions: - Break the test codeblock so it is viewable without scrolling ```bash tox -e integration -- 'tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[my_dataset]' ``` into ```bash tox -e integration -- \ 'tests/integration/public_dataset_processing_test.py::test_public_dataset_processing[my_dataset]' ``` -...

Regarding the CI log warnings: ```log /home/runner/work/pymovements/pymovements/docs/source/tutorials/adding-public-dataset.ipynb:20009: WARNING: 'myst' cross-reference target not found: 'basic' [myst.xref_missing] /home/runner/work/pymovements/pymovements/docs/source/tutorials/adding-public-dataset.ipynb:20012: WARNING: 'myst' cross-reference target not found: 'intermediate' [myst.xref_missing] ``` Seeing you want to reference...

Removing the version limit, running with `polars=1.35.2`, we get '64 failed, 2890 passed, 10 xfailed'. Most of them are repetitive. I summarise: 1. DeprecationWarnings: `assert_frame_equal` Argument Renaming (28) **Issue**: The...

We should choose a fitting test for the message field, if it is required, as you said. Looking into some random repositories, it occurs to me many have kept exactly...

As of now I am getting the patch diffs on Ci, again, and the codecov batch on the repo homepage is shown. Was this the concern of this issue? If...

I would try to reproduce the errors: > [...] at one point every test threw this message: > >> warnings.warn(message, category, **kwargs) >E RuntimeWarning: More than 20 figures have been...

The closing of plots is independent of the plotting interface. Figures need to be closed in any case, also for the non-interactive interface. I am able to get the `RuntimeWarning`:...

Sorry, I only read the PR before testing, not all the comments. > As the resource links are now up-to-date and can be downloaded, I would like to treat #1346...