Carlson Büth

Results 44 comments of Carlson Büth

This PR is ready, except waiting on 100% test coverage of the dependent PR.

> Great, thanks! I have some minor change requests regarding the complete removal of `_metadata` and testing public functions vs private functions. Thank you for the fast review. I integrated...

I splitted the validations /calibrations test and undid the changes to `test_from_asc_example_file_has_expected_metadata`.

@dkrako `pymovements` works great with the current release `3.14`. I found two issues: - The `databooks-meta` hook fails badly. Looking into their repo, it seems like they have not been...

For the download problem we might want to consider sending a cheap preflight request, so we can raise the `OSError` on http status and never enter `urlretrieve`. Alternatively, we'd need...

I have pushed some commits and updated the PRs text, trying to reach an MVP for some of the features. @saeub, if you have availability, feel free to read through.

> Wow this PR is massive and is taking a great direction! Thank you for the valuable review! > I think there are some things that could be improved, but...

Agreed, after having this run with the DIDEC tests, I would like to double-check the implementation with the DIDEC files. I will change the draft status when it's done.

The `didec.py` and `.yml` has a sampling freq of 1000Hz, but the dataset files all seem to have "## Sample Rate: 250". I'd change the definitions. https://github.com/pymovements/pymovements/blob/0cd011d3616cb7ccf0bd0a5c655f6e7d250236c5/src/pymovements/datasets/didec.py#L156

> Awesome, thanks for all the effort regarding the tests! How do we want to proceed? > > I released a new pymovements version yesterday. I think it's fine to...