Carlson Büth
Carlson Büth
@theDebbister Task 1, 3, and 5 have been implemented in #1361, as prioritized.
This should be covered by #1013. The solution is under review.
@theDebbister Thank you for the valuable report of this silent data loss! The snippet made it easy to analyse what happens, still, I modified it to make it more robust....
I do think that if labs are using such split file structures with hierarchical attributes as folder names, it would be good to support it in some way. If I...
After implementing your suggestions, the PR is ready to review. Few test CI jobs failed twice due to a download issue https://github.com/pymovements/pymovements/actions/runs/19638124722/job/56236998651?pr=1359, which should be unrelated to the changes.
> > ``` > > * [x] Solution for (2): Only map one AOI to each fixation and warn user about overlapping AOIs. > > -> [5c896da](https://github.com/pymovements/pymovements/commit/5c896da762ee413287fb84cfe4860933e5666b27) > > ```...
As discussed in the dev meeting, the restriction for (2) in 5c896da762ee413287fb84cfe4860933e5666b27 has been undone, only resulting in warnings, see 0172b2a.
After adding coverage for some hard to reach cases with 9995f5ad6c0a725ec9d6b6f72548ec2800674f92, this is now at 100% diff coverage, and ready to be merged.
ToDo: Add a test with previous saccades in events dataframe. Assure they are untouched after `map_to_aois()`.
Thank your for the reminder, I added a quite specific test for this. It should still be a unit test, but quite large. The `data` could be parametrised still. When...