Clemens Brunner
Clemens Brunner
Then you are already pretty much doing what I'm doing 😄!
Probably not next week, maybe the week after. I have to finish a paper revision and some other stuff. But we should decide if we want to replace `EDFlib-Python` with...
I think the slowness comes from our own loop here: https://github.com/mne-tools/mne-python/blob/main/mne/export/_edf.py#L240-L268 `pyEDFlib` doesn't require users to loop over blocks, because it accepts a list of NumPy arrays (one element per...
But it's an external package with wheels and an optional dependency. NumPy has tons of compiled code and we're not thinking about a pure Python alternative.
Exactly. I think in this case the speedup might be worth the tradeoff.
Exports with pyEDFlib worked fine when I tried it, all files opened in EDFbrowser with no problems.
MNELAB exports using pyEDFlib: https://github.com/cbrnr/mnelab/blob/main/mnelab/io/writers.py#L46
Probably forgotten, thanks for the bug report 😄!
I would like to add a second EDF export function that uses `pyEDFlib`, so export works if either that package or `EDFlib-Python` is installed. Is this possible with our utility...
OK, then I'll just replace it with my implementation.