Christophe Bornet comments

Results 183 comments of


                                            Christophe Bornet

Something wrong happened with the change of git branch 😢

> Something wrong happened with the change of git branch 😢 fixed it.

Rebased on master now that v1 was released.

> Hey @cbornet, if you update against master, can help get this across the line Rebased against latest master.

@sydney-runkle I rebased again and updated the deprecation version. Can you take a look ?

Impressive work @blambov ! I added a few comments, mostly cosmetics. Otherwise LGTM!

Hi, could this get some eyes ? It's on the path to activate `warn_unreachable` on `core`.

> would you mind rebasing? @mdrxy done.

It seems you rolled-back your changes in the latest commits. The PR doesn't do anything relevant anymore...

> Should we go ahead and make the input and output types public here? Done. This also removed 2 ruff warnings 😃