Christophe Bornet
Christophe Bornet
> b) Making sure that the copyright holder(s) (Salesforce I believe) will not call foul at any point, and provide some guidance about what the revived/forked project can do have...
@severfire , do you have more details on which API calls you do ? Minimal steps to reproduce would be helpful.
@serverfire several leaks have been fixed. Can you check again on main branch ?
@ogabrielluiz I fixed `TestChatInput`. Can you check again ?
Why not. But I'm not a typing expert...
@pgier there's a test failure: https://github.com/apache/pulsar/actions/runs/4664751844/jobs/8257572250?pr=18440#step:11:1521 Can you check ?
Oh, sorry I missed that ! The PR has been opened for more than 2 years ?! Feel free to merge any of them. With your latest https://github.com/fruch/testcontainers-python/commit/2b238a227b00445bdef42427f1504fc87081800e they are...
The problem is that this PR would treat composition as inheritance which is wrong. Also in the issue definition it's not clear if subsubmodel composes submodel or inherits from it....
Imagine the following : B1 has A1 with a discriminator in its allOf. B2 has A2 with a discriminator in its allOf. C has B1 and B2 in its allOf....
The solution here would be to look recursively into the interfaces tree for the discriminator field and set the parent accordingly if any.