Christophe Bornet comments

Results 166 comments of


                                            Christophe Bornet

✅ Detect blocking calls in coroutines using BlockBuster

> It might be useful to put this on Discussion board as well Done : https://github.com/fastapi/fastapi/discussions/13296

✅ Detect blocking calls in coroutines using BlockBuster

Thiis PR aims at protecting from writing code that blocks the event loop. Like doing a sync network call, a `time.sleep`, and so on. If you do so and the...

✅ Detect blocking calls in coroutines using BlockBuster

Updated blockbuster version to fix CI issues.

✅ Detect blocking calls in coroutines using BlockBuster

Hi. Could this PR be reviewed (or discussed in the discussion thread if needed) ?

[Java] Support custom ok-http authenticators

Is subclassing the best way ? Why are the authentications unmodifiable in the first place ?

CNDB-8641: Add a metric to count all request errors

Yes. Tests are on the TODO. I just wanted to be sure that it's going in the right direction (so much for TDD...)

CNDB-8641: Add a metric to count all request errors

@JeremiahDJordan I added some tests.

Add Astra DB vector store

@microsoft-github-policy-service agree company="DataStax"

Add Astra DB vector store

Rebased to fix conflict. @AlonsoGuevara @jgbradley1 is it possible to review this PR ?

False positive: No overload variant of "asdict" matches argument type "Type[DataclassInstance]" [call-overload]

I'm not sure it's a false positive. If `is_dataclass` narrows to `Type[DataclassInstance] | DataclassInstance`, then you need to ensure it's not `Type[DataclassInstance]` before passing to `asdict`. From your example, it...