langflow icon indicating copy to clipboard operation
langflow copied to clipboard

fix: Use AsyncSession in memory

Open cbornet opened this issue 1 year ago • 3 comments

Use AsyncSession in memory

cbornet avatar Nov 18 '24 12:11 cbornet

CodSpeed Performance Report

Merging #4665 will degrade performances by 48.12%

Comparing cbornet:async-memory-2 (4d07eaa) with main (b2691ee)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 11 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-memory-2 Change
test_get_and_cache_all_types_dict 1,232.5 µs 867 µs +42.15%
test_successful_run_with_input_type_any 258 ms 347.7 ms -25.81%
test_successful_run_with_input_type_text 178.9 ms 344.8 ms -48.12%
test_successful_run_with_output_type_debug 253.4 ms 345.4 ms -26.64%

codspeed-hq[bot] avatar Nov 18 '24 12:11 codspeed-hq[bot]

@ogabrielluiz I fixed TestChatInput. Can you check again ?

cbornet avatar Nov 18 '24 13:11 cbornet

Hey @cbornet

This is a very dangerous PR so we'll wait until next week to merge it. Just in case we need to release a patch this week.

ogabrielluiz avatar Nov 26 '24 00:11 ogabrielluiz