cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

CNDB-8641: Add a metric to count all request errors

Open cbornet opened this issue 4 months ago • 4 comments

What is the issue

https://github.com/riptano/cndb/issues/8641

What does this PR fix and why was it fixed

This pull request introduces new metrics for tracking invalid and other error requests for CQL statements, and integrates these metrics into the query failure notification logic. The main changes are the addition of the AllRequestsMetrics class, updates to the ClientRequestsMetrics class to include these new metrics, and modifications to the query event notification methods to record errors using the new metrics.

cbornet avatar Sep 04 '25 17:09 cbornet

Checklist before you submit for review

  • [ ] This PR adheres to the Definition of Done
  • [x] Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • [x] Use NoSpamLogger for log lines that may appear frequently in the logs
  • [x] Verify test results on Butler
  • [x] Test coverage for new/modified code is > 80%
  • [x] Proper code formatting
  • [x] Proper title for each commit staring with the project-issue number, like CNDB-1234
  • [x] Each commit has a meaningful description
  • [x] Each commit is not very long and contains related changes
  • [x] Renames, moves and reformatting are in distinct commits
  • [x] All new files should contain the DataStax copyright header instead of the Apache License one

github-actions[bot] avatar Sep 04 '25 17:09 github-actions[bot]

Yes. Tests are on the TODO. I just wanted to be sure that it's going in the right direction (so much for TDD...)

cbornet avatar Sep 04 '25 22:09 cbornet

@JeremiahDJordan I added some tests.

cbornet avatar Sep 08 '25 16:09 cbornet

:heavy_check_mark: Build ds-cassandra-pr-gate/PR-1983 approved by Butler


Approved by Butler See build details here

cassci-bot avatar Oct 06 '25 10:10 cassci-bot