Chris Bielow

Results 172 comments of Chris Bielow

Yes, can surely be done. But it requires some code changes. I'd say a day worth of work (including tests etc)

this should be merged at some point in the near future. Any further comments? splitting this into smaller, equally-sized chunks is probably not feasible (dependencies...), unfortunately

thanks for the review :) I'm still in the process of fixing a few compiler warnings on AppleClang... but should not be long before ready to merge.

this is hard to solve since the parameters originate from a DefaultParamHandler inside OpenMS and not from a TOPP inputfile. And the handler does not know about input files. Also:...

still, cannot reproduce ``` c:\dev\openmsqt5_build>bin\Release\MSSimulator.exe -test -in c:\dev\openmsqt5\src\tests\topp\DecoyDatabase_1.fasta -out bla.mzML -algorithm:RandomNumberGenerators:biological reproducible -algorithm:RandomNumberGenerators:technical reproducible Loading sequence data from c:\dev\openmsqt5\src\tests\topp\DecoyDatabase_1.fasta ... done (3 protein(s) loaded) Starting simulation 2020/04/20, 16:50:42: Digest Simulation...

if the file are not available I get a hard warning (rightfully so): ``` bin\Release\MSSimulator.exe -test -in c:\dev\openmsqt5\src\tests\topp\DecoyDatabase_1.fasta -out bla.mzML -algorithm:RandomNumberGenerators:biological reproducible -algorithm:RandomNumberGenerators:technical reproducible -algorithm:MSSim:RT:HPLC:model_file examples/simulation/RTPredict.model2 Loading sequence data from...

these are not example files, but the default models. Without them, simulator will not run. so, yes, please include them :)