Christian Bespin comments

Results 8 comments of


                                            Christian Bespin

Building issue

Thanks for looking into this. I could not get pylandau to work with python 3.12 for myself, but the problem seems far from trivial. Might even be connected to the...

Logging mechanism for warnings

Thanks for the PR! Although the changes are not the cause of the failing pipelines I would like to check those quickly to make sure that everything works for future...

Logging mechanism for warnings

Merged this, will check the tests later

Use python's in-built logging module

Thanks for the suggestion! I completely agree, but have very limited time currently for support. Since the fix is minimal, could you provide a pull request?

Use python's in-built logging module

Sorry, that I did not come to this sooner. I will deal with it probably next week if nobody opens a merge request

ValueError: numpy.ndarray size changed, may indicate binary incompatibility

Thanks for reporting this and sorry for the late reply. I observed similar issues that should be resolved with the latest release. What numpy version are you using? Can you...

ValueError: numpy.ndarray size changed, may indicate binary incompatibility

@IrisP25 The current version works well for me with numpy 1.26.2 (see environment below). Can you provide me with more information about your python environment? And try the package in...

Question: Unused const in pylandau_src.cpp ?

Good catch, thanks! I will look into it, I have no experience with discrete convolutions (yet) and did not write that code.