pylandau icon indicating copy to clipboard operation
pylandau copied to clipboard

Use python's in-built logging module

Open umute97 opened this issue 3 years ago • 3 comments

More of a feature request: At the moment, warnings and errors are printed out via print() functions. I suggest using the logging module to filter feedback from pylandau based on a verbosity level.

This happens on the latest release pylandau==2.2.1.

Example

WARNING: sigma > 100 * eta can lead to oszillations. Check result.

umute97 avatar Sep 19 '22 12:09 umute97

Thanks for the suggestion! I completely agree, but have very limited time currently for support. Since the fix is minimal, could you provide a pull request?

cbespin avatar Jan 23 '23 12:01 cbespin

I second that. The warning is quite annoying and I'd like to be able to silence it

guigoruiz1 avatar Aug 22 '24 15:08 guigoruiz1

Sorry, that I did not come to this sooner. I will deal with it probably next week if nobody opens a merge request

cbespin avatar Aug 22 '24 16:08 cbespin