Chris Beer

Results 180 comments of Chris Beer

Closing this; I think #2670 is probably the sprockets-less way forward.

That makes a lot of sense to me. Our first stab at implementing it is pretty basic, and there's obviously room for enhancement. On the surface, this seems like a...

#2576 replaced the autocomplete implementation, and hopefully/presumably github's is better.

It looks like the Bootstrap 4 margins may be significantly larger than the old ones.

Updated https://github.com/projectblacklight/blacklight/wiki.

:+1: Also, we should package some of our `SearchBuilder` specs the same way.

There isn't a great seam for doing this; the best we came up with in one of our apps was: https://github.com/sul-dlss/dlme/blob/master/app/controllers/spotlight/home_pages_controller.rb#L32-L37 Maybe some work in `Blacklight::Solr::Repository` could push caching down...

Hm. That seems weird. Are you using highlight fields or model accessors, by any chance?

I think `catalog/document` is still a useful seam (for doing e.g. `render document`, if nothing else) 🤷‍♂️

We also touch on some approaches in the customizing blacklight workshop: https://workshop.projectblacklight.org/v8.0.0.alpha/extending-catalog-controller/ https://workshop.projectblacklight.org/v8.0.0.alpha/dynamic-catalog-configuration-using-before_actions/