Chris Bachhuber

Results 29 comments of Chris Bachhuber

Thanks for all your input! I will read into cpplint and propose how I would like to approach the code style topic in the next days/weeks. Also thanks for you...

Continuing on this topic, I would like to add a license message to the header files in `include/CLI` and to the respective files in `examples` to satisfy cpplint's `legal/copyright` check....

I'm fine with these solutions - @henryiii, what do you think?

I would like to use clang-tidy's [readability-identifier-naming](https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html) to ensure consistent capitalization of code elements. I saw that quite often, classes and structs are used as 'variables', so I would not...

What is the plan with this PR? Continue working on it or close it? I can also try to pick up the work

Right, but we would still need to enable file handling (and therefore, this feature) for windows under C++11, correct? Consequently, I would prefer to implement it for Windows & C++11...

Right, thanks for drawing :+1: I guess implementing this makes sense when the framework is flexible enough to support multiple sensor inputs. Currently, I don't see a large benefit of...

> @cbachhuber I moved the conversation to this issue, instead of a closed pr :) The one and only correct thing to do :sweat_smile: :+1: > Commit 36232e0 should fix...

> no visible degrade in quality Let me just ask this one off-topic question here: do you have plans for an objective performance measurement? I.e. a module that compares the...

I'm also not seeing a significant difference, unfortunately. | Branch | Init Time | Iteration Time | |--------------------------|-----------|----------------| | master | 1384ms | 132-174ms | | reduce_thread_divergence | 1384ms |...