Chris Bachhuber

Results 29 comments of Chris Bachhuber

True, with ROS things do look different. I advise against a separate ROS branch. As you say, that's not nice to maintain and not visible. As a middle ground, it...

Sounds good :+1: Slightly related to folder structure: what are your criteria for removing the WIP disclaimer from this repository? Maybe you want to open an issue for gathering those.

Right, I already found that as well. I'm quite sure, however, that not the demo project is the problem, but that we are linking everything together to an executable. So...

Fixed! See [this build](https://github.com/cbachhuber/dynamic-occupancy-grid-map/runs/596279413) :)

[This answer](https://stackoverflow.com/a/27487567/7260972) writes `GLEW_LIBRARIES` instead of `GLEW_LIBRARY`. Also [cmake documentation](https://cmake.org/cmake/help/latest/module/FindGLEW.html) promotes `GLEW_LIBRARIES`. So I used that, and it works :) PR incoming ;)

It seems that something else is needed. I just created a new branch, but with only the `GLEW_LIBRARIES` change it does not compile. I suggest that I clean up branch...

Master: ``` DOGM cycle stats (14 splits): Minimum: 62ms Median: 70ms Mean: 69.5ms Maximum: 84ms ``` This branch: ``` DOGM cycle stats (14 splits): Minimum: 66ms Median: 70ms Mean: 70.7143ms...

That works perfectly fine, thank you! However, it's not super elegant to pass a private member into this free function. Would it make sense that class `JunitXml`/`TestSuite` provides member function...

I see what you mean, but a `dict` is a well-established data structure in python, hence it is much more accessible and interoperable with other python tools. In my specific...