Maxwell Keonwoo Kang

ReactiveDictionary: What is isDisposed used for since it never changes?

1

I was making a class inherits `ReactiveDictionary` and when I inspect source of it, there is `isDisposed`. ```csharp [NonSerialized] bool isDisposed = false; ``` and it's used to check if...

Suggestion: Access to loop variable in closure

2

If you access loop variable from closure, variable value will change as loop continues. This can cause unintended behaviour and such accesses are generally discouraged. It will be helpful if...

We could use `versionDefines` of `asmdef` to make it only enabled when `Addressable Assets` package is included Until this get included, user can define their own.

Consideration about link.xml

1

AOT code stripping could affect reflection. BakingSheet has been deployed link.xml with .unitypackage. But this needs to be tested again since we moved to embedded package. Also, Unity does not...

Access sheet ids with `CurrencySheet.Ids.Gold` or `sheetContainer.Currency.Rows.Gold`

giving choice to pick which sheet property to export

https://docs.unity3d.com/Packages/[email protected]/manual/QuickStartGuideWithVariants.html

This will be interesting and well match with concept of BakingSheet However there will be some complication like compatibility with Unity, version check, `IsExternalInit` issue, etc.

"Comparison to null is expensive" warning can be misleading

3

The warning, [Avoid null comparisons against UnityEngine.Object subclasses](https://github.com/JetBrains/resharper-unity/wiki/Avoid-null-comparisons-against-UnityEngine.Object-subclasses) shows for this code: ``` if (obj != null) DoSomething(); ``` But not showing for this code: ``` if (obj) DoSomething(); ```...

Remove unused configuration from gmake2

4

**What does this PR do?** Remove `env.PathVars` (notice the capitalization) that had no effect. **How does this PR change Premake's behavior?** Shouldn't change any behavior as it has wrong name...