premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

Remove unused configuration from gmake2

Open cathei opened this issue 1 year ago • 4 comments

What does this PR do?

Remove env.PathVars (notice the capitalization) that had no effect.

How does this PR change Premake's behavior?

Shouldn't change any behavior as it has wrong name and not referenced.

Anything else we should know?

N/A

Did you check all the boxes?

  • [x] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [x] Add unit tests showing fix or feature works; all tests pass
  • [x] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [x] Follow our coding conventions
  • [x] Minimize the number of commits
  • [x] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

cathei avatar Sep 18 '23 02:09 cathei

Any reason to remove this, rather than rename is properly to pathVars?

nickclark2016 avatar Sep 18 '23 03:09 nickclark2016

Any reason to remove this, rather than rename is properly to pathVars?

This was my thought process:

  • If the values are identical to tokens from fileconfig, then there would be no point of re-defining here.
  • If the values are not identical, then it might break existing scripts that use tokens, due to behavior change.

cathei avatar Sep 18 '23 03:09 cathei

As I remember, it might be useful only for cases with absolute = true (as other values are identical as without pathvars)...

But I would say our handling of absolute is strange anyway (we have %{!path} to turn/keep absolute path, %{absolute_path_token} might turn into relative path (inside %[path])).

Created project-tokens to test tokens.

Jarod42 avatar Sep 18 '23 12:09 Jarod42

@cathei do you mind pushing up an empty commit to retrigger actions? Once they're triggered and pass I should be able to merge this.

nickclark2016 avatar Dec 15 '23 12:12 nickclark2016