Casper Meijn comments

Results 115 comments of


                                            Casper Meijn

build(deps): update itertools requirement from >=0.10, <=0.12 to >=0.10, <=0.13

@dependabot recreate

build(deps): update itertools requirement from >=0.10, <=0.12 to >=0.10, <=0.13

The suggested version range is still not what I expected. I send another PR upstream: https://github.com/dependabot/dependabot-core/pull/9956

build(deps): update itertools requirement from >=0.10, <=0.12 to >=0.10, <=0.13

@dependabot recreate

Transition to `quote` + `syn` for code generation.

> Unsure how much else there's to split up. I suggest the following to make reviewing easier: - Split off "this PR removes manual indentation handling, delegating it to the...

prost-build: Extract file descriptor loading from compile_protos()

> Thanks @caspermeijn! What is the next step for this PR to be merged? There you go

getter/setter generated for optional enum fields should use Option

I agree. Are you willing to do the work?

getter/setter generated for optional enum fields should use Option

Would this PR also address your problem? https://github.com/tokio-rs/prost/pull/1079 It changes the field type to `Option`. `OpenEnum` had a `known()` helper function that returns `Option`.

Support for adding derive annotations for traits outside prost?

You can derive any trait you want using `type_attribute` as commented earlier. For example to derive Arbirary on every protobuf type: ```rust prost_build::Config::new() .type_attribute(".", "#[derive(arbitrary::Arbitrary)]") .compile_protos(&["src/types.proto"], &["src/"])?; ``` If this...

fix getter/setter generated for optional enum fields should use option

@giangndm I am preparing a breaking change. Are you still interested in this PR? If so, please update the code.

Use workspace dependencies.

What problem does this solve? Dependabot will change all uses of a dependency when there is an update, right?