Casper Meijn

Results 115 comments of Casper Meijn

I don't understand what this issue is. It seems to me this is a `tonic` issue. Could you add instructions for how to reproduce this? The best way to do...

I did some work to automatically derive `Eq` where possible in https://github.com/tokio-rs/prost/pull/1175 That has not yet been released. Can you verify the clippy warnings are fixed on the main branch...

I think this is a very interesting idea. I had always thought a trait would be required to make something like this work. Prost had an `encoding` module, the is...

One drawback of the modules is the lack of generics. Therefore, you can't make one encoding module that works for every boxed type.

> Are you able to see the CI output to iterate on this? So I have been a bit dumb and just committed this CI job without testing. I will...

I have not been able to make this work. Some of the transient dependencies have wrong minimal dependencies. I have found a few crates where the minimal dependencies have been...

The way I see it, `struct Foo` can never be constructed. prost will create a default instance of Foo during decoding, which will stack overflow. The C++ implementation solves this...

> CI is currently failing, for reasons unclear to me. All CI failures are due to this error: > > ``` > no function or associated item named `new` found...

> Yes, that's what I used in my pbjson update, but either way, it's a breaking change if you want to support unknown Fields No, this PR is not a...

`petgraph 0.8` requires feature `std`, which is fine, as `prost-build` already requires `std`