Casper Meijn

Results 115 comments of Casper Meijn

Will this break compatibility with proto2/closed enums? Personally, I don't use proto2, so I am not sure whether it is properly supported at all.

I think it makes sense to provide a migration guide.

What is the error message for a `i32` field with `#[prost(enumeration)]`? Can we detect that scenario and print a nice error message?

I would like to see some tests for `OpenEnum`.

Have thought some more about this PR: I don't want to break users in this way. At least not now. I suggest making this an option in `prost-build` so that...

How are default values handles in this solution? Especially default values set for a specific field in the proto file.

I believe the openssl example is different from that is needed for prost. The needed `protoc` binary is based on the host architecture and not the target architecture, right? Could...

Yeah, you are right. [cargo::rustc-env=VAR=VALUE](https://doc.rust-lang.org/cargo/reference/build-scripts.html#rustc-env) will not work for you. If you call [`prost_build::Config::compile_protos()`](https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.compile_protos) somewhere in your own codebase, then you can set the correct `PROTOC` env var before that....

Sorry, now I understand your problem. You don't own all the crates that use prost in your dependency chain. Personally, I would make sure the path of the development environment...

The version range suggested by Dependabot is incorrect. I send a PR upstream to have this fixed: https://github.com/dependabot/dependabot-core/pull/9828