Casey Eickhoff

icon company @Adobe

Results 37 comments of Casey Eickhoff

[Bug]: Tooltip and Popover (with tip) should have the same distance from trigger in overlay-trigger with same offset value

Hello @spdev3000 in order to help us triage your issue, [can you please review our bug severity classification guide](https://github.com/adobe/spectrum-web-components/blob/main/CONTRIBUTING.md#issue-severity-classification) and provide us with the appropriate severity classification? Please update the...

feat: migrated to changesets from lerna

@blunteshwar can we add some jsdoc descriptions at the top of the task files to explain what the task is used for and what the output is at the top?

feat: migrated to changesets from lerna

Also, sorry for being late to the review, but can we still separate ignored packages and the getWorkspacePackages function to their own file? Perhaps in a utility folder inside tasks?...

chore: migrate workflows from circleci to github actions [SWC-767]

> To validate the above, open a pull request for the test branch update against main and let CI do its thing. > > Expect a comment to be added...

chore: copyright formatting throughout [CSS-1224]

LGTM

`visualDiff` of `@web/test-runner-visual-regression` can't be imported

@bashmish can you share the process of getting this issue resolved?

[DO NOT MERGE]: Testing code coverage stuff

@TarunAdobe can we close this PR or what is this for?

fix(menu): allow keyboard events to propagate from opened menu

@rubencarvalho @nikkimk @TarunAdobe can we confirm if the menu omnibus accessibility work addressed this issue? or what conversations do we need to have to update the status on this PR?

fix(OverlayTrigger): conditionally attach slotchange listener

@jcmitch @Rajdeepc @rubencarvalho was this PR issue resolved in the merged PR #4689 and can thus be closed? Or does this PR need review still?

feat(card): update the card background color property name

@Rajdeepc does this PR need to be updated or closed? Also flagging it as `BREAKING CHANGE` will trigger a major version? Is that necessary for a mod token change?