Casey Eickhoff comments

Results 37 comments of


                                            Casey Eickhoff

chore: update dependency css-loader to v7.1.2

Just calling out this is only used in the example project and should be considered to be removed or better integrated in the migration to Spectrum 2

chore: update dependency mini-css-extract-plugin to v2.9.2

Just calling out this is only used in the example project and should be considered to be removed or better integrated in the migration to Spectrum 2

fix(overlay): default listenerHost to target in overlay-trigger-directive

@TarunAdobe can you include the manual testing steps in the PR description?

fix(overlay): default listenerHost to target in overlay-trigger-directive

When testing overlay from this link: https://swcpreviews.z13.web.core.windows.net/pr-5873/docs/storybook/?path=/story/overlay-directive--default The overlay does not open and im receiving this in the console:

fix(colorarea): remove layout thrashing and cache selectors

@tjgupta can you please include detailed testing instructions? Also should this cause a visual change at all, I'm seeing a large number of VRT failures? caveat: please don't update the...

fix(colorarea): remove layout thrashing and cache selectors

Also can you added an automated test if possible to cover this code?

chore(reactive-controllers): updates lit dependency

@graynorton @Rajdeepc what was the outcome of the convo mentioned above? Do we still support Lit2? If so we should get this in