Francesco Casella comments

Results 1758 comments of


                                            Francesco Casella

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> Or I guess we might want to only do it if we're not going to run the backend afterwards, since that's one of the first things the backend then...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> Sorry, I missed that you were already doing check model. In that case you get the message: > > ``` > Check of M completed successfully. > Class M...

Clarifications in Section 3.7 and 5.6.1 regarding "builtin classes"

Of course builtin should be spelled built-in also in Section 5.6.1.2

Clarifications in Section 3.7 and 5.6.1 regarding "builtin classes"

My main concern when opening this ticket was about _consistency_. The MLS has been written over the years by many different persons and groups and some parts were later rewritten...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> > That was my idea. So is CheckModel part of backend? > > No, CheckModel is the module used by the API, i.e. what OMEdit uses when you press...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> The simplest fix is to remove the message "Check of M completed successfully" from the output of `checkModel` and simply show the rest of the result i.e., > >...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

Wait, the thing is slightly more complicated. If you check a Modelica.Fluid model with unredeclared Medium package, it may lack some equations in the BaseProperties models (which are partial). Of...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

Well, how deep CheckModel goes with the structural analysis is ultimately up to us to decide. Going too deep is not a good idea, because if the component is unconnected,...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

Can you just carry around a flag during flattening, and make it true when you encounter a partial class (instead of generating an error and quit)?

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> Can you just carry around a flag during flattening, and make it true when you encounter a partial class (instead of generating an error and quit)? @perost, I'm trying...