Francesco Casella

Results 1758 comments of Francesco Casella

I played around a bit with this model: ```modelica model TestEditing extends SOFCPoliMi.Tests.BenchmarkCammarata; annotation(uses(SOFCPoliMi)); end TestEditing; ``` which is definitely non-trivial. In general it works quite well, I like it....

@dietmarw would you mind opening a separate ticket for that?

Original trac ticket: https://trac.openmodelica.org/OpenModelica/ticket/5217.

The issue is very clearly visible in the [verification plot](https://libraries.openmodelica.org/branches/newInst-daeMode/ScalableTestSuite_noopt/files/ScalableTestSuite_noopt_ScalableTestSuite.Thermal.Advection.ScaledExperiments.SimpleAdvection_N_200.diff.der(Ttilde[1]).html) of der(Ttilde[1]) of ScalableTestSuite.Thermal.Advection.ScaledExperiments.SimpleAdvection_N_200. The saved results are not smooth but follow a stair-cased pattern that sometimes actually falls outside...

> Seems like a crucial error and i don't know how that one slipped by for so long. I will see if i can fix it. Good that we caught...

> There is only one model failing, but while analyzing it i just realized that there could be something way more basic wrong here. > > We talked about arrays...

> This only refers to initialization right? Or does this still hold for simulation? I understand this always applies. There is no mention in the specification of the initialization phase....

It passed the compiler testuite. Let's see what happens to the [library testsuite](https://libraries.openmodelica.org/branches/history/master/).

We did get some improvements in Buildings, see [report](https://libraries.openmodelica.org/branches/history/master/2021-09-03%2012:09:04..2021-09-03%2022:56:45.html), but not in the models reported in [#6199](https://trac.openmodelica.org/OpenModelica/ticket/6199) and [6207](https://trac.openmodelica.org/OpenModelica/ticket/6207), I guess you need to dig more. There were also some...

See comment [here](https://github.com/OpenModelica/OpenModelica/pull/7853#issuecomment-912848421)