Jason Carver

Results 98 comments of Jason Carver

2012 had a "may fix". I think it's highly unlikely that this is resolved. Closing this issue would definitely require confirmation.

> Validate that the number is correctly applied. Yup a [quick search](https://github.com/ethereum/py-evm/search?q=EIP170_CODE_SIZE_LIMIT&unscoped_q=EIP170_CODE_SIZE_LIMIT) shows that it is functioning correctly. https://github.com/ethereum/py-evm/blob/ae1e3e4fc133f36db2238f61dac05a4e4e344319/eth/vm/forks/spurious_dragon/computation.py#L41 --- > consider making the number match and modifying the condition...

Looks like #1933 has some steps toward BLS support, though that seems to not be in the Berlin roadmap anymore.

I haven't dived deep into what's going on with this code yet. This isn't really an answer to your question, but an alternative would be to follow the model of...

Unfortunately, we aren't currently putting any resources toward new features like this in py-evm (though forking mainnet is definitely a cool one that we've talked about, and would like some...

Thanks for writing this up @relyt29 ! It really helps get things moving.

Hm, looks like someone got part-way through adding tests for `vm.execute_bytecode`. At first glance it looks like it could be a useful test, not sure why it got abandoned.

Like maybe this: https://github.com/ethereum/py-evm/blob/0cd3ebac9c7c336b07f2f52c52b069fbe400bcef/tests/json-fixtures/test_virtual_machine.py#L199-L215 Should be replaced with: ```py computation_getter(fixture, code, vm) ```

It looks like so far they are both used only privately and a couple places. AFAICT, the tension comes from these two goals: 1. We don't want `VM.import_block` to just...

@cburgdorf since you started taking a look at Berlin already, do you mind coordinating this review?