Jason Carver
Jason Carver
@kclowes I guess you're probably blocked on Felipe for London work anyway, so maybe you could start on this?
> Any failing benchmark scripts should cause CI to fail. Where passing presumably means both correctness and within some tolerance of a performance target.
> What's the reason these would not just be a couple new pytest tests? The detailed console output? There are a number of parameters you might want to tweak when...
This is probably done, just need to run through all the proposed benchmarks to see if any are missing (and split them out into new issues)
Silly question inbound: is there any time that leading 0s matter in bytes? Like is there ever a difference between `b'\0' and b'\0' *32` on the stack? I assume not,...
I'd also like to think through eip centric forking. We have bundled-fork centric forking in py-evm now, and it looks like it will be helpful or required to be able...
My instinct: > Let's assume we try to persist a checkpoint header and notice the header already exists, should we check the score of it? Yes > And what if...
I just did a quick run-through, and everywhere that uses it seems to be doing it correctly. This place in particular would break if `account_exists` always returned `not account_is_empty`: https://github.com/ethereum/py-evm/blob/32834ab5d2b6ae509509b620cde9290506eec7bd/eth/vm/forks/spurious_dragon/state.py#L32-L35...
> How about `account_present_in_trie` Yeah, that's way better
> [Chia-Network/bls-signatures](https://github.com/Chia-Network/bls-signatures) is under the license Apache 2.0. From my understanding, since we only import the library, from the rules in Apache 2.0, it seems not to affect our license....