Unclear Parameter in `test_vm_fixtures`

Open akiannillo opened this issue 6 years ago • 3 comments

In this test here is unclear the use of the parameter computation_getter in the function definition. Is it actually used in some way I cannot see?

May 21 '19 10:05 akiannillo

It does appear un-used. Looks safe to remove.

May 21 '19 12:05 pipermerriam

Hm, looks like someone got part-way through adding tests for vm.execute_bytecode. At first glance it looks like it could be a useful test, not sure why it got abandoned.

May 22 '19 00:05 carver

Like maybe this: https://github.com/ethereum/py-evm/blob/0cd3ebac9c7c336b07f2f52c52b069fbe400bcef/tests/json-fixtures/test_virtual_machine.py#L199-L215

Should be replaced with:

computation_getter(fixture, code, vm)

May 22 '19 00:05 carver