Carter Anderson

Results 468 comments of Carter Anderson

Looks like we drop from 1700 characters to 450 characters. Are we sure the added flexibility is worth it, especially in light of the increased size?

Ah right I forgot we switched to the subset. In light of that this seem like an acceptable move (provided we're happy with how the font behaves in practice). Can...

> Given that there seems to be a healthy ecosystem of personal blogs [1](https://jms55.github.io/posts/2024-06-09-virtual-geometry-bevy-0-14/) [2](https://johanhelsing.studio/posts/extreme-bevy), [virtual meetups](https://rustunit.com/blog/2024/04-15-bevy-meetup/), [conference talks](https://rustconf.com/programs/#679) that already can/do get amplified by Bevy's official social media accounts,...

`Mut` is one of the hottest paths in Bevy. I'm concerned about the performance implications of introducing _anything_ (even the cheapest ops) to it. I'd like to either see compelling...

`AiSystems` feels a _bit_ too generic to me. "AI" can be arbitrary app logic, whereas "Physics" is more often handled in a specific "physics step".

> In light of https://github.com/bevyengine/bevy/issues/12660, I would vote against adding more panicking shorthands like components. I think discouraging unwrap/panicking variants entirely (as in, not providing impls) would have pretty nasty...

Left some replies in #12660

> I find this kind of funny. Thinking about this historically, this feels like we've inverted the relationship between Query::get_component and EntityMut/EntityRef with this change. Haha yeah thats an interesting...

Welp this PR is sadly stalled until we sort out this problem: https://github.com/bevyengine/bevy/pull/13375#discussion_r1602135098 Not sure there will be a solution that doesn't involve doing access checks on each call.

I think the best we can hope for is "allocation free check every entry against every other entry" (similar to `query.many_mut`), but accomplishing that will require significant changes (or at...