Carter Anderson
Carter Anderson
I'm thinking this code/module should probably be behind a feature flag. I'm not convinced bevy devs need this compiled into their apps by default.
Relevant conversation here: https://discord.com/channels/691052431525675048/1248074018612051978/1276270114517418116
In that conversation we reached consensus that the last two cases above shouldn't behave that way (implicitly "flattening" the text layout in nested Text hierarchies). Instead, the rule would simply...
Pulling in @viridia, who was part of this conversation on discord.
> One more question: it looks like the fallback constructor is Default. Why not make it FromWorld for both consistency and more expressiveness? Given that the constructors are called mid-insertion,...
> Seems like this doesn't work with hooks/observers as the required components aren't in the added array in BundleInfo (which is the current source of truth). Hmm yeah I'll look...
Just slimmed down the size of `AddBundle` by only storing the Required Component constructor on it (instead of also including the ComponentId). Given that AddBundle will be high-frequency, better to...
A collection of "big" todos for this PR: * [x] Support generic requires (this was on my pre-PR todo list but I missed it) * [x] Support hooks / observers...
Just fixed hooks/observers, which included a refactor of BundleInfo + AddBundle to improve clarity about the scope of the components being accessed. Also added more tests.
I've addressed all comments. The big changes since the opening the PR: * Generics and full type paths in `#[requires()]` are now supported * Hooks and observers now work with...