Carter Anderson

Results 468 comments of Carter Anderson

I'm also on board for making Bevy less panicky. But I don't think we should seriously consider removing panicking APIs or renaming `get_x` to `x` until we have made error...

Note that Result systems _are_ already supported. However you need to manually convert them to "normal systems" using `map`: ```rust app.add_systems(Update, a_system.map(error)); fn a_system(query: Query) -> Result { let a...

We'd also want our own `Result` error type similar to `anyhow` (in that it can support arbitrary error types via boxing).

I'm also partial to this in my own code as I don't _love_ typing/reading `Ok(())` at the end of every system: ```rust const OK: Result = Ok(()); fn system() ->...

Just outlined what I think our plan should be here: https://github.com/bevyengine/bevy/issues/14275#issuecomment-2223708314

Is the bevy_editor_pls vendoring necessary or could it use a git reference? Vendoring will make it hard to stay up to date, and also bloats the repo, so it should...

We're gonna need to adapt this to the omni light changes. A naive merge conflict resolution resulted in no shadows being drawn.

This is probably due to the projection calculation being done in the frag shader? (we probably need to adjust it to account for the depth changes?)

The current bias produces pretty significant artifacts: ![image](https://user-images.githubusercontent.com/2694663/124678963-78db1e80-de78-11eb-9c63-a202a9518c95.png) It feels like the "acceptable bias window" is much smaller. `0.07` is too high (casted shadows stop working as expected) and `0.03`...