Carlin MacKenzie

Results 95 comments of Carlin MacKenzie

In #458, I created the following proof of concept with several frameworks https://codepen.io/carlinmack/pen/LYyBdZo I've written a comment besides each option, the library is linked in the heading and I tried...

sorry was meant to describe. If you click on a point in the three charts I mentioned, it will write the date and value of that point below the chart....

Quite a few of these look serious!

LGTM is closing in December https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/ I'll look into this

![image](https://user-images.githubusercontent.com/6676843/195083142-51aae2da-54f0-45c1-b619-8a81ca58f838.png) I'll make a PR per class of error for ease of reviewing, and list them here too: - [x] 2 alerts of Flask app is run in debug mode...

It is easy to fix this error by replacing `i` with `_`: ![image](https://user-images.githubusercontent.com/6676843/195096173-5de037df-bd4c-4d32-ad1e-0f55c576deca.png) However I think that the for loop could be replaced with its body https://github.com/WDscholia/scholia/blob/master/scholia/_version.py#L498-L499

I've also read into this and I don't think it's a problem for us ![image](https://user-images.githubusercontent.com/6676843/195666485-0a6602ce-3a82-44f2-8f53-8b3cd1edf06e.png) Perhaps we could use `search` instead: "[`findall()` matches all occurrences of a pattern, not just...

All issues have been been considered :) See above

Can the new search be added to this page https://scholia.toolforge.org/search? @DanielFLopez

I think you're misunderstanding me. The search with autocomplete is already available on the home page and every other page. This search box https://scholia.toolforge.org/search does not have the autocomplete.