Carlin MacKenzie

Results 95 comments of Carlin MacKenzie

Using https://commons.wikimedia.org/wiki/File:Refresh_icon.svg which has CC0 licence for the button icon Edit: Decided not to use an image as it adds complexities with light/dark mode and hover states

Refreshing iframes seems to be extraordinarily difficult :( I think perhaps for security reasons? Will mark this as ready for review Edit: for details: changing the `src` which is the...

Didn't realise that 2 of my other PRs interacted with this code making it quite tricky to rebase 😅 All sorted now after some testing Are there any other issues...

I've just added an `if` around existing code but the diff looks so much more complicated than that, apologies

* I think white-padding is best * but what if the emoij has been edited since the padding was added? We shouldn't add another step to the process to remember...

* yes I think adding the padding on export is a much better solution * hmm I have no idea why that's the case * yep there's definitely a way...

![image](https://user-images.githubusercontent.com/6676843/83978582-866d5000-a8d6-11ea-91c2-e77dc39eccad.png) So it unfortunately appears that the reason that the padding is "uneven" is because of the two different ways to define strokes another problem is that if we use...

btw my intention for this isn't actually to overwrite the file, but output this so export-svg can use it. I'm just overwriting the file for debugging etc now. I recommend...

I think a better approach would be to complete the strokes in the line-supplement layer, and then generate the padding with only the line and line-supplement layer. If we really...

![image](https://user-images.githubusercontent.com/6676843/84578026-4521e800-ad8f-11ea-80a6-40b32346c5b2.png) I've generated all the assets and pushed it to my repository so we can see them https://carlinmack.github.io/openmoji/index.html Please use the SVG version and the black background as the PNGs...