Carl Dea

Results 9 comments of Carl Dea

Niall, Sorry for the slow reply. My response is below: > Could you explain what this will do? Will it add a second CI integration? > GitHub Actions has some...

Not sure about the last check related to the Eclipse Foundation's Contributor Agreement. I signed up and submitted the info.

> @carldea what email address did you use for the Eclipse Contributor Agreement? It is carl.dea at gmail.com as opposed to carldea at gmail.com, in GitHub it's run together. Thank...

> @carldea ah, ok, did you sign-off your commits with `git commit -s`? > No, but will do. > Each commit needs to be signed off; I know it is...

@jnh5y Somehow my Eclipse Foundation account is confused with my carldea vs carl.dea email. I made a PR to replace this one to: https://github.com/locationtech/jts/pull/646

@jnh5y I believe everything is ready for the merge. Not sure why the Eclipse Foundation legal agreement row above is complaining. Any ideas?

> Is this still fairly fast to run CI? It's nice if the CI is as fast as possible, to make PR turnaround quick. I think so, especially when you...

@jnh5y James, > Ah, it is complaining since the commits are not signed-off. So sorry for the trouble. > > When I need to sort this, I checkout the tip...

@jnh5y @dr-jts All ready to go. I was able to squash commits and re-verified my Eclipse Foundation email/key info.